-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-3777): set tls options per kms provider #235
Conversation
bindings/node/index.d.ts
Outdated
@@ -203,7 +203,13 @@ export interface ClientEncryptionOptions { | |||
/** | |||
* TLS options for kms providers to use. | |||
*/ | |||
tlsOptions?: ClientEncryptionTLSOptions; | |||
tlsOptions?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLS options to KMS providers are configured on a per KMS provider basis for future flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one minor (non-blcoking) comment. Otherwise the changes look good to me
Note Prose and spec tests are located in the main Node repo. Related PR mongodb/node-mongodb-native#3070
Node CSFLE run against this specific branch: https://spruce.mongodb.com/version/61e753873066153369a025de/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC