GODRIVER-2685 Simplify the writeconcern API. #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2685-simplify-wc
branch
2 times, most recently
from
18bdc1c
to
867a496
Compare
qingyang-hu
reviewed
Apr 19, 2023
qingyang-hu
reviewed
Apr 19, 2023
qingyang-hu
reviewed
Apr 19, 2023
matthewdale
force-pushed
the
godriver2685-simplify-wc
branch
from
c6574a2
to
02872bf
Compare
qingyang-hu
approved these changes
Apr 26, 2023
matthewdale
force-pushed
the
godriver2685-simplify-wc
branch
2 times, most recently
from
4e664bb
to
8d16e8f
Compare
matthewdale
force-pushed
the
godriver2685-simplify-wc
branch
from
8d16e8f
to
7c1a7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2685
Summary
Remove the functional options pattern, export all fields in the
WriteConcernstruct so users can set them directly, and add package functions for quickly specifying common write concernsw: "majority",w: 0, andw: 1. Since users can now set any value to the exportedWfield, add type validation logic in theMarshalBSONValuefunction that returns an error ifWis not a supported type, and add tests for the new error logic.Background & Motivation
The
writeconcernpackage and types use a lot of unnecessary APIs that can confuse users. Additionally, there are no helper functions for specifying common write concerns like there are for thereadconcernandreadprefpackages. Remove the functional options pattern, export all fields in theWriteConcernstruct so users can set them directly, and add package functions for quickly building common write concernsw: "majority",w: 0, andw: 1.