GODRIVER-2910 Add durations to connection pool events. #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./eventcompatible changesPoolEvent.Duration: added |
matthewdale
added
priority-1-high
prestonvasquez
previously approved these changes
Apr 5, 2024
matthewdale
dismissed stale reviews from prestonvasquez and qingyang-hu
via
9ce96e8
prestonvasquez
approved these changes
Apr 9, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 94dfdff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2910
Summary
Durationfield toevent.PoolEvent.Durationon "ConnectionReady", "ConnectionCheckedOut", and "ConnectionCheckOutFailed" events.Background & Motivation
Users have asked for the ability to measure the duration of some processes that the connection pool performs that can contribute to increased latency, increased errors, or other issues if not monitored and tuned correctly. Those requested measurements are: