GODRIVER-3145 Don't retry on context timeout or cancellation. #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver3145-dont-retry-ctx
branch
from
6e7a964
to
64cf6f8
Compare
API Change ReportNo changes found! |
matthewdale
force-pushed
the
godriver3145-dont-retry-ctx
branch
2 times, most recently
from
3596325
to
2edc4ec
Compare
matthewdale
force-pushed
the
godriver3145-dont-retry-ctx
branch
from
2edc4ec
to
a135db3
Compare
matthewdale
added
priority-1-high
prestonvasquez
requested changes
Apr 12, 2024
prestonvasquez
approved these changes
Apr 12, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3145
Summary
Background & Motivation
Currently the driver can start to retry an operation if the operation times out during certain phases of execution. If that happens, the operation may return a confusing error message that obfuscates the original error. Instead, the driver should return the original error if it was caused by a
context.Canceledorcontext.DeadlineExceeded.