RUST-1631 Always use polling monitoring when running in a FaaS environment #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Feb 15, 2024
| @@ -34,10 +34,12 @@ impl Stats { | |||
|
|
|||
| fn handle_sdam(&mut self, event: &SdamEvent) { | |||
| match event { | |||
| SdamEvent::ServerHeartbeatStarted(_) => { | |||
| SdamEvent::ServerHeartbeatStarted(ev) => { | |||
| assert!(!ev.awaited); | |||
There was a problem hiding this comment.
Rather than setting patchable: true so this is included in the evergreen runs and then (forget to) change it back before submitting, I just did an independent run for that.
| @@ -102,13 +117,19 @@ impl Monitor { | |||
| while self.is_alive() { | |||
| let check_succeeded = self.check_server().await; | |||
|
|
|||
| if self.topology_version.is_some() && self.allow_streaming { | |||
There was a problem hiding this comment.
The spec changed from allowing drivers to use a dedicated RTT monitor even when polling to requiring that one not be used when polling, so starting up that task had to be deferred to the point where we know whether polling is happening or not.
isabelatkinson
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1631
The core change is pretty simple - add some behavior to switch back to polling when FaaS is detected - but there's a lot of stuff around that (tests, URI config, etc.)