RUST-1713 Bulk Write #1034
RUST-1713 Bulk Write #1034
Conversation
isabelatkinson
force-pushed
the
bulk-write
branch
from
9269180 to
f9c5997
Compare
isabelatkinson
force-pushed
the
bulk-write
branch
from
f790451 to
a491642
Compare
| options: BulkWriteOptions, | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for WriteModel { |
There was a problem hiding this comment.
serde doesn't allow configuring different values for whether an enum should be "tagged" for serialization and deserialization, which requires a manual impl here
| @@ -75,6 +81,12 @@ const MAX_ENCRYPTED_WRITE_SIZE: usize = 2_097_152; | |||
| // The amount of overhead bytes to account for when building a document sequence. | |||
| const COMMAND_OVERHEAD_SIZE: usize = 16_000; | |||
|
|
|||
| /// Context about the execution of the operation. | |||
| pub(crate) struct ExecutionContext<'a> { | |||
There was a problem hiding this comment.
Future-proofing against the annoyance of having to add a new parameter to every implementation of handle_response...
| description: impl AsRef<str>, | ||
| ) -> std::result::Result<(), String> { | ||
| let description = description.as_ref(); | ||
| pub(crate) fn verify_result(&self, error: &Error, description: impl AsRef<str>) { |
There was a problem hiding this comment.
This might just be personal preference, but returning string errors here rather than performing assertions was making these errors feel very opaque because a) they require us to write errors ourselves rather than use the standard format of assertion and panic error messages and b) we lose info about the exact line where the error occurred. We were just unwrapping the error returned from this method anyway so I don't think we were getting much benefit from this.
src/test/util/fail_point.rs
Outdated
There was a problem hiding this comment.
Did a surface-level refactor of this because I thought the old implementation was causing me problems (I was actually just forgetting to store the FailPointGuard being returned, added #[must_use] on that type). In retrospect this PR is probably not the place for extra stuff so I can pull this out into another PR it's too distracting 🙂
|
@abr-egn thank you 🙂 |
Implement support for the new
bulkWritecommand. This PR can be reviewed in tandem with the specification changes (mongodb/specifications#1534).I've left some things out of this PR to minimize its size and ensure that it will be a digestible reference implementation. Additional tickets can be found in RUST-1282.