RUST-1149 Prose tests for change streams. #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jan 18, 2022
| .await; | ||
| new_stream.map(|cs| cs.with_type::<T>()) | ||
| })); | ||
| // Iterate the loop so the new future gets polled and can register wakers. |
There was a problem hiding this comment.
This was the point of wrapping the logic in a loop - there needs to be an underlying future that's been polled rather than just returning Poll::Pending directly because with the latter this future will never be polled again due to the lack of registered wake conditions.
| /// The [`Namespace`] containing the database and collection in which the change occurred. | ||
| Namespace(Namespace), | ||
| #[derive(Deserialize, Debug, PartialEq, Eq)] | ||
| pub struct ChangeStreamEventSource { |
There was a problem hiding this comment.
is it possible this could change in the future? if so, we should keep it non_exhaustive
|
|
||
| let (client, coll, mut stream) = match init_stream("track_resume_token", false).await? { | ||
| Some(t) => t, | ||
| None => return Ok(()), |
There was a problem hiding this comment.
can we log that we're skipping due to topology here? (in the spirit of #523)
There was a problem hiding this comment.
init_stream logs when it returns None :)
abr-egn
changed the title
isabelatkinson
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1149
This implements the prose tests for change streams, with the exception of test 6, which is (a) tricky to observe and (b) essentially guaranteed to be correct by the design of the Rust driver. Some relatively minor updates were required to the change stream implementation as a result of bugs found by these tests.