RUST-1220 Bump outdated dependencies #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
bump-dependencies/RUST-1220
branch
from
32764ac to
34a06e3
Compare
isabelatkinson
force-pushed
the
bump-dependencies/RUST-1220
branch
from
81cdf0c to
367c47c
Compare
isabelatkinson
commented
Mar 21, 2022
| @@ -146,11 +145,24 @@ fn make_rustls_config(cfg: TlsOptions) -> Result<rustls::ClientConfig> { | |||
| } | |||
| }; | |||
|
|
|||
| ClientConfig::builder() | |||
There was a problem hiding this comment.
ClientConfig was made mostly opaque in favor of a builder, documentation here. This branch calls with_single_cert on the builder which corresponds to the set_single_client_cert method we were calling on the config previously. The else branch uses the defaults suggested in the docs, which are also in line with the now-removed new function we were calling previously.
| trust-dns-proto = "0.20.0" | ||
| trust-dns-resolver = "0.20.0" | ||
| typed-builder = "0.9.0" | ||
| trust-dns-proto = "0.21.1" |
There was a problem hiding this comment.
I ended up needing to bump these rather than waiting for #591 because the older versions were incompatible with the new version of async-std-resolver.
patrickfreed
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps all of our outdated dependencies (excluding the few that are covered in #591). Also increases the MSRV to 1.51.0 (new MSRV for
pbkdf2). The most significant breaking changes were due to updates in rustls; you can reference the changelog here.