RUST-1420 Cache AWS credentials received from endpoints #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
commented
Jun 27, 2023
| @@ -496,3 +557,45 @@ impl ServerFirst { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
I added this module to avoid making the mutex and various fields pub(crate) just for the sake of testing.
| @@ -1066,8 +1066,8 @@ tasks: | |||
| - func: "run aws auth test with assume role credentials" | |||
| - func: "run aws auth test with aws credentials as environment variables" | |||
| - func: "run aws auth test with aws credentials and session token as environment variables" | |||
| - func: "run aws auth test with aws EC2 credentials" | |||
| - func: "run aws ECS auth test" | |||
| # - func: "run aws auth test with aws EC2 credentials" | |||
|
I'm fixing up the MSRV failure but this is ready for review otherwise. |
abr-egn
approved these changes
Jun 27, 2023
| #[cfg_attr(feature = "async-std-runtime", async_std::test)] | ||
| async fn credential_caching() { | ||
| // This test should only be run when authenticating using AWS endpoints. | ||
| if var("SKIP_CREDENTIAL_CACHING_TESTS").is_ok() { |
There was a problem hiding this comment.
It might make the evergreen config a little less noisy if this were an enable rather than a skip. That's just a vague inclination, though, so feel free to disregard if you feel otherwise :)
There was a problem hiding this comment.
I thought about doing that originally (agreed this is more noisy), but I'd prefer for these tests to be opt-out rather than opt-in so that we don't forget to enable them if we add a new mechanism using an endpoint in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.