Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in MSRV-Cargo.lock #981

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Oct 24, 2023

ahash 0.8.3 and older were yanked because of a security vulnerability, and 0.8.4 (with a bug) and 0.8.5 were released to address that. ahash 0.8.5 requires Rust 1.61+. As a result, the Evergreen task for mongo-rust-driver that checks MSRV compilation started to fail.

There was also a change in the zerocopy license, so deny.toml had to be updated.

mongodb/bson-rust#436 is the corresponding PR in bson-rust.

RUST-1780

…o.lock`

`ahash` 0.8.3 and older were yanked because of a security vulnerability,
and 0.8.4 (with a bug) and 0.8.5 were released to address that.
`ahash` 0.8.5 requires Rust 1.61+. As a result, the Evergreen task for
`mongo-rust-driver` that checks MSRV compilation started to fail.

There were also a change in the `zerocopy` license,
so `deny.toml` had to be updated.
Copy link
Member Author

@stIncMale stIncMale Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in searchindex.json only the MSRV was updated to 1.61.0. But because both files are huge one-liners, the change is not reviewable as rendered by GitHub. How do you usually update the manual? Maybe you build it from ./manual, and then replace the whole ./docs/manual in a separate commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we regenerate the contents of docs/manual in the same PR that updates manual/src; the generated files don't need to be reviewed so it's not an issue that github doesn't render them.

As a side note, we'll likely be dropping this manual entirely in the nearish future since we have official docs now :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since this PR updates manual/src/README.md, I built the book and committed the result.

Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abr-egn abr-egn merged commit 5858750 into mongodb:main Oct 25, 2023
@stIncMale stIncMale deleted the RUST-1780 branch October 25, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants