Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUST-1676 Simplify GenericCursor by refactoring the GetMoreProvider trait into a generic struct #983

Merged
merged 2 commits into from
Oct 31, 2023
Merged

RUST-1676 Simplify GenericCursor by refactoring the GetMoreProvider trait into a generic struct #983

merged 2 commits into from
Oct 31, 2023

Conversation

stIncMale
Copy link
Member

abr-egn
abr-egn approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Really happy to see that the two parallel GetMoreProvider implementations could indeed be merged.

isabelatkinson
isabelatkinson approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is a nice simplification! I will merge this one in as well

@isabelatkinson isabelatkinson merged commit 4f7402d into mongodb:main Oct 31, 2023
@stIncMale stIncMale deleted the RUST-1676 branch October 31, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelatkinson isabelatkinson isabelatkinson approved these changes

@abr-egn abr-egn abr-egn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stIncMale @abr-egn @isabelatkinson