CLOUDP-244156: Fix the concurrent writes for the ResourceWatcher #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-karpukhin
requested review from
helderjs,
s-urbaniak,
josvazg and
roothorp
s-urbaniak
requested changes
Apr 18, 2024
There was a problem hiding this comment.
@igor-karpukhin please let's make sure that the event handlers that also maintain maps are synchronized or guaranteed to be used within the same goroutine only.
I just checked. This map is used to be passed to the |
helderjs
approved these changes
Apr 18, 2024
s-urbaniak
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Fix the concurrent writes for the ResourceWatcher
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).