🚀 [READY FOR REVIEW] MONGOID-5564 Code Docs: Make it a rule to use full namespaces in code doc #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
changed the title
…oids ambiguity for example between Mongoid::Document and BSON::Document. This PR includes the change for the following classes: - Mongoid::Document - Mongoid::Criteria - Mongoid::Association::Proxy - Mongoid::Criteria::Queryable Any stragglers missed can be fixed on an ongoing basis.
johnnyshields
force-pushed
the
docs-full-namespaces
branch
from
009e104
to
e68482e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only includes changes to code docs -- no logic changes
The changes for #5547 are also included here for de-confliction purposes. Please merge that one first
Code Docs: Make it a rule to use full namespaces in code doc. This avoids ambiguity for example between
Mongoid::DocumentandBSON::Document.This PR includes the change for the following classes:
Mongoid::DocumentMongoid::CriteriaMongoid::Association::Relatable(from MONGOID-5563 Code Docs: Correctly use Mongoid::Association::Relatable instead of Mongoid::Association #5547)Mongoid::Association::ProxyMongoid::Criteria::QueryableAny stragglers missed can be fixed on an ongoing basis.