MONGOID-5590 - Docs: Clarify that shard key dot limitation comes from MongoDB server #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goDB server, not from Mongoid.
johnnyshields
changed the title
|
@jamis ready to merge. |
johnnyshields
changed the title
jamis
changed the title
|
@jamis any reason why this doc-only PR can't be merged? |
|
@johnnyshields -- I think this might not be true anymore. For v6 of the database, I think you're right (https://www.mongodb.com/docs/v6.0/core/dot-dollar-considerations/), but the current docs (https://www.mongodb.com/docs/manual/core/dot-dollar-considerations) make no mention of that restriction. The page you're linking to in the docs seems to flatly contradict the statement that dots and dollar signs are not supported. If you can find another page for the current server version (v7) that says that dots and dollar signs are forbidden in shard keys at the server level, please do update the PR. Otherwise, I think this PR might be obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per DOCS-15993, the limitation of dot in shard keys comes from MongoDB server, not from Mongoid.
This is a follow-up to #5588