Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-5508 touch on custom field #5829

Merged

Conversation

adviti-mishra
Copy link
Contributor

This branch adds a spec to touchable_spec.rb to test whether the symbol representing the field to touch provided to the touch option is indeed touched. Two extra models - Band and Label - were also added to touchable_spec_model.rb for this. See https://jira.mongodb.org/browse/MONGOID-5508 for more.

@adviti-mishra adviti-mishra marked this pull request as draft June 10, 2024 20:33
@adviti-mishra adviti-mishra marked this pull request as ready for review June 10, 2024 20:35
@adviti-mishra adviti-mishra marked this pull request as draft June 11, 2024 14:48
@adviti-mishra adviti-mishra marked this pull request as ready for review June 11, 2024 14:48
@adviti-mishra adviti-mishra requested a review from jamis June 11, 2024 15:08
Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@adviti-mishra adviti-mishra merged commit a5657dc into mongodb:master Jun 11, 2024
54 of 56 checks passed
@adviti-mishra adviti-mishra deleted the 5508-touch-on-custom-field branch June 11, 2024 15:36
@jamis jamis changed the title 5508 touch on custom field MONGOID-5508 touch on custom field Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants