MONGOID-5806 Rails 7.2 Support #5852
Conversation
|
Thank you! Tracking this here: https://jira.mongodb.org/browse/MONGOID-5806 |
There was a problem hiding this comment.
Hi @AlexKovynev, thank you for your contribution! Just one remark from our side, otherwise looks good!
mongoid.gemspec
Outdated
| @@ -38,7 +38,7 @@ Gem::Specification.new do |s| | |||
| # Ruby 3.0 requires ActiveModel 6.0 or higher. | |||
| # activemodel 7.0.0 cannot be used due to Class#descendants issue | |||
| # See: https://github.com/rails/rails/pull/43951 | |||
| s.add_dependency("activemodel", ['>=5.1', '<7.2', '!= 7.0.0']) | |||
| s.add_dependency("activemodel", ['>=5.1', '<8.0', '!= 7.0.0']) | |||
There was a problem hiding this comment.
| s.add_dependency("activemodel", ['>=5.1', '<8.0', '!= 7.0.0']) | |
| s.add_dependency("activemodel", ['>=5.1', '<7.3', '!= 7.0.0']) |
Since Mongoid heavily depends on some ActiveModel internals, we should be careful with the upper limit.
There was a problem hiding this comment.
But rails's next version is already 8.0...?
https://edgeguides.rubyonrails.org/8_0_release_notes.html
There was a problem hiding this comment.
@comandeo-mongo as @PikachuEXE said the next version is 8.0 we don't have 7.3 but if you want ok :) DONE
AlexKovynev
force-pushed
the
Rails72Support
branch
from
c06d980
to
dd1f464
Compare
Co-authored-by: AlexKovynev <alexkovynev@gmail.com> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
Co-authored-by: AlexKovynev <alexkovynev@gmail.com> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
Co-authored-by: AlexKovynev <kovyniev.oleksii@gmail.com> Co-authored-by: AlexKovynev <alexkovynev@gmail.com>
|
Hello @comandeo-mongo 👋 Do you know when the next release will be for Mongoid? Eagerly awaiting this PR for Rails 7.2 support 😄 Thank you for all your hard work maintaining this project 🙏 |
|
@AleksanderBodurri we are going to release new versions of 9.x and 8.x with Rails 7.2 support this week. Sorry for the delay, and thanks for your patience! |
No description provided.