refactor(topologies): pass errors back from selectServer

The legacy topology types sometimes return an error, or a null server to indicate selection failed.
mongodb · Aug 13, 2019 · 097d3b9 · 097d3b9
1 parent c3bfc05
commit 097d3b9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/core/topologies/mongos.js b/lib/core/topologies/mongos.js
@@ -1130,6 +1130,11 @@ Mongos.prototype.selectServer = function(selector, options, callback) {
   options = options || {};
 
   const server = pickProxy(this, options.session);
+  if (server == null) {
+    callback(new MongoError('server selection failed'));
+    return;
+  }
+
   if (this.s.debug) this.emit('pickedServer', null, server);
   callback(null, server);
 };

diff --git a/lib/core/topologies/replset.js b/lib/core/topologies/replset.js
@@ -1111,6 +1111,16 @@ ReplSet.prototype.selectServer = function(selector, options, callback) {
   }
 
   const server = this.s.replicaSetState.pickServer(readPreference);
+  if (server == null) {
+    callback(new MongoError('server selection failed'));
+    return;
+  }
+
+  if (!(server instanceof Server)) {
+    callback(server, null);
+    return;
+  }
+
   if (this.s.debug) this.emit('pickedServer', options.readPreference, server);
   callback(null, server);
 };