chore(NODE-2998): move connection-string parsing into separate package #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed earlier this year, this moves the connection string parsing into a separate package for mongodb-connection-string-specific URL parsing. The code in that package is based very closely on the original code in the driver here.
dariakp
added
Primary Review
dariakp
approved these changes
Jun 24, 2021
durran
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
As discussed earlier this year, this moves the connection string
parsing into a separate package for mongodb-connection-string-specific
URL parsing. The code in that package is based very closely on the
original code in the driver here.
Are there any files to ignore?
No.