Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-3606): legacy and new versions of the CSFLE library #2999

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

nbbeeken
Copy link
Contributor

Our "custom-csfle" has been expanded to run the 1.x version
and our normal tests will use the Node-API version.

@nbbeeken nbbeeken requested review from dariakp and durran October 13, 2021 20:05
@dariakp dariakp added the Team Review Needs review from team label Oct 13, 2021
@dariakp
Copy link
Contributor

dariakp commented Oct 13, 2021

@nbbeeken The description on the jira ticket says:

When we release the next major version of mongodb-client-encryption our 3.x branch which tests on older versions of node will need to install csfle@1 while Node.js 12+ variants can install csfle@2

The 4.x branch can be left alone to install the latest csfle always.

so is there an update that needs to happen for 3.x? and I guess 4.x doesn't actually install latest, it's still pinned to a major version

@nbbeeken
Copy link
Contributor Author

Thanks for catching that, just made #3002 to backport the CI change. I also realize we'll want this for kerberos.

@dariakp dariakp merged commit 808d7da into 4.1 Oct 14, 2021
@dariakp dariakp deleted the NODE-3606/test-latest-fle branch October 14, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants