Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-3606): legacy and new versions of the CSFLE library #3002

Merged
merged 5 commits into from
Oct 14, 2021
Merged

test(NODE-3606): legacy and new versions of the CSFLE library #3002

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76b1465
test(NODE-3606): legacy and new versions of the CSFLE library
nbbeeken Oct 13, 2021
2dc14db
test legacy and Node-API kerberos versions
nbbeeken Oct 13, 2021
0c92dc3
fix version parsing
nbbeeken Oct 13, 2021
7a53f6a
chore: gate kerberos version on nodejs version
nbbeeken Oct 14, 2021
19ba899
fix: add env variable
nbbeeken Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .evergreen/run-kerberos-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ fi
echo "Running kinit"
kinit -k -t "$(pwd)/.evergreen/drivers.keytab" -p ${KRB5_PRINCIPAL}

npm install kerberos
set -o xtrace
npm install kerberos@">=2.0.0-beta.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does kerberos not require a particular node version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing Node.js version condition here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's node 14 installing kerb >= 2 and node 6 installing kerb ^1.1.7

npm run check:kerberos

npm install kerberos@"^1.1.7"
npm run check:kerberos
set +o xtrace

# destroy ticket
kdestroy
10 changes: 7 additions & 3 deletions .evergreen/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# set -o xtrace # Write all commands first to stderr
set -o errexit # Exit the script with error if any of the commands fail

Expand Down Expand Up @@ -52,8 +52,12 @@ if [[ -z "${CLIENT_ENCRYPTION}" ]]; then
unset AWS_ACCESS_KEY_ID;
unset AWS_SECRET_ACCESS_KEY;
else
npm install mongodb-client-encryption@latest

NODE_MAJOR_VERSION=$(echo $NODE_VERSION | cut -d. -f1)
if [[ $NODE_MAJOR_VERSION -ge 12 ]]; then
npm install mongodb-client-encryption@">=2.0.0-beta.0"
else
npm install mongodb-client-encryption@"^1.2.7"
fi
# Get access to the AWS temporary credentials:
echo "adding temporary AWS credentials to environment"
# CSFLE_AWS_TEMP_ACCESS_KEY_ID, CSFLE_AWS_TEMP_SECRET_ACCESS_KEY, CSFLE_AWS_TEMP_SESSION_TOKEN
Expand Down