Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4767): Change abstract cursor return type #3531

Merged
merged 5 commits into from
Jan 20, 2023
Merged

feat(NODE-4767): Change abstract cursor return type #3531

merged 5 commits into from
Jan 20, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 20, 2023 •
edited
Loading

Description

Change the return type of the AbstractCursor's asyncIterator implementation to AsyncGenerator

Is there new documentation needed for these changes?

Yes. Added note in upgrade guide to mention type change.

What is the motivation for this change?

Narrowing the Typescript types for better developer experience.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests

@dariakp dariakp changed the title fix(NODE-4767): Change abstract cursor return type feat(NODE-4767): Change abstract cursor return type Jan 20, 2023
@dariakp dariakp changed the title feat(NODE-4767): Change abstract cursor return type feat!(NODE-4767): Change abstract cursor return type Jan 20, 2023
@dariakp dariakp changed the title feat!(NODE-4767): Change abstract cursor return type feat(NODE-4767)!: Change abstract cursor return type Jan 20, 2023
@W-A-James W-A-James changed the title feat(NODE-4767)!: Change abstract cursor return type feat(NODE-4767): Change abstract cursor return type Jan 20, 2023
@W-A-James W-A-James marked this pull request as ready for review January 20, 2023 22:01
@dariakp dariakp merged commit 410ef30 into main Jan 20, 2023
@dariakp dariakp deleted the NODE-4767/change_abstract_cursor_return_type branch January 20, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @dariakp