-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-5791): type error with $addToSet in bulkWrite #3953
Merged
nbbeeken
merged 10 commits into
main
from
NODE-5647-type-error-with-addtoset-in-bulkwrite
Jan 3, 2024
Merged
fix(NODE-5791): type error with $addToSet in bulkWrite #3953
nbbeeken
merged 10 commits into
main
from
NODE-5647-type-error-with-addtoset-in-bulkwrite
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
changed the title
fix(NODE-5647): type error with $addToSet in bulkWrite
fix(NODE-5791): type error with $addToSet in bulkWrite
Dec 20, 2023
…with-addtoset-in-bulkwrite
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Dec 20, 2023
nbbeeken
requested changes
Dec 20, 2023
…with-addtoset-in-bulkwrite
nbbeeken
requested changes
Jan 2, 2024
nbbeeken
approved these changes
Jan 2, 2024
nbbeeken
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Jan 2, 2024
durran
approved these changes
Jan 3, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
update
methods forCollection
andBulkWrite
with$addToSet
should not show a type error for collections with shema, collections extended from theDocument
/any
type, and fields ofany
type.What is changing?
update
inCollection.UpdateOneModel
/Collection.UpdateManyModel
/BulkWrite.updateOne
/BulkWrite.updateMany
becomesUpdateFilter<TSchema> | Document[]
.SetFields
type helper skips validation for fields ofany
type (provided by custom interface or index signatures).Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5647
NODE-4664
Release Highlight
The type error with
$addToSet
inbulkWrite
was fixedPreviously the following code sample would show a type error:
It happened because the driver's
Document
type falls back toany
, and internally we could not distinguish whether or not this assignment was intentional and should be allowed.After this change, users can extend their types from
Document
/any
, or use properties ofany
type and we skip the$addToSet
validation in those cases.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript