Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3470): retry selects another mongos #3963

Merged
merged 5 commits into from
Jan 19, 2024
Merged

feat(NODE-3470): retry selects another mongos #3963

merged 5 commits into from
Jan 19, 2024

Conversation

durran
Copy link
Member

@durran durran commented Jan 12, 2024

Description

When retrying reads and writes on a sharded cluster, will attempt the retry on a different mongos if multiple mongoses are present.

What is changing?

  • executeOperation now keeps track of the previously selected server.
  • Server selection will now attempt to exclude the previous server when the topology is sharded and multiple mongoses are present.
  • Adds unit tests for server selection and prose tests for retryable reads and writes.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-3470

Release Highlight

When retrying reads or writes on a sharded cluster, the driver will attempt to select a different mongos for the retry if multiple are present.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-3470 branch 10 times, most recently from 348cc5c to d8fb63b Compare January 16, 2024 14:42
@durran durran marked this pull request as ready for review January 16, 2024 15:10
@alenakhineika alenakhineika self-requested a review January 16, 2024 17:13
@alenakhineika alenakhineika added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 16, 2024
@durran durran requested a review from alenakhineika January 17, 2024 11:58
@alenakhineika alenakhineika added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 17, 2024
@alenakhineika alenakhineika merged commit 84959ee into main Jan 19, 2024
27 checks passed
@alenakhineika alenakhineika deleted the NODE-3470 branch January 19, 2024 15:14
@alenakhineika alenakhineika removed the Team Review Needs review from team label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants