Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5945): make AWS session token optional #4006

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Feb 29, 2024

Description

Backport optional AWS session token fix.

What is changing?

Do not throw the MongoMissingCredentialsError('Could not obtain temporary MONGODB-AWS credentials') exception when the AWS token is missing.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5945

Release Highlight

The AWS token is now optional

Users may provide an AWS_SESSION_TOKEN as a client option or AWS configuration in addition to a username and password. But if the token is not provided, the driver won't throw an exception and let AWS SDK handle the request.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review February 29, 2024 22:13
@nbbeeken nbbeeken changed the title fix(NODE-5945): backport to 5.x optional AWS session token fix(NODE-5945): make AWS session token optional Mar 1, 2024
@nbbeeken nbbeeken self-assigned this Mar 1, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 1, 2024
@alenakhineika alenakhineika added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 5, 2024
@nbbeeken nbbeeken merged commit cbaf47a into 5.x Mar 5, 2024
11 of 25 checks passed
@nbbeeken nbbeeken deleted the NODE-5945-backport-optional-aws-session-token branch March 5, 2024 14:44
aditi-khare-mongoDB pushed a commit that referenced this pull request Mar 7, 2024
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants