-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(NODE-5986): parallelize SRV/TXT resolution #4012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small thing I noticed while looking at the driver code, this is a quick win to improve connection establishment performance.
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Mar 4, 2024
durran
approved these changes
Mar 4, 2024
Just verifying from spec: "TXT records MAY be queried either before, in parallel, or after SRV records." |
durran
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Mar 4, 2024
nbbeeken
changed the title
chore(NODE-5986): parallelize SRV/TXT resolution
perf(NODE-5986): parallelize SRV/TXT resolution
Mar 4, 2024
nbbeeken
approved these changes
Mar 4, 2024
5 tasks
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small thing I noticed while looking at the driver code, this is a quick win to improve connection establishment performance.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Query SRV and TXT records in parallel
When connecting using a convenient SRV connection string (
mongodb+srv://
) hostnames are obtained from an SRV dns lookup and some configuration options are obtained from a TXT dns query. Those DNS operations are now performed in parallel to reduce first-time connection latency.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript