Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6365): pass through allowPartialTrustChain TLS flag #4228

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat(NODE-6365): pass through allowPartialTrustChain TLS flag #4228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d07ca7
feat(NODE-6365): pass through `allowPartialTrustChain` TLS flag
addaleax Sep 9, 2024
398ae33
Merge branch 'main' into 6365-dev
addaleax Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cmap/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ export async function prepareHandshakeDocument(

/** @public */
export const LEGAL_TLS_SOCKET_OPTIONS = [
'allowPartialTrustChain',
'ALPNProtocols',
'ca',
'cert',
Expand Down
3 changes: 2 additions & 1 deletion src/connection_string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,8 @@ export const OPTIONS = {
// Custom types for modifying core behavior
connectionType: { type: 'any' },
srvPoller: { type: 'any' },
// Accepted NodeJS Options
// Accepted Node.js Options
nbbeeken marked this conversation as resolved.
Show resolved Hide resolved
allowPartialTrustChain: { type: 'any' },
minDHSize: { type: 'any' },
pskCallback: { type: 'any' },
secureContext: { type: 'any' },
Expand Down
6 changes: 4 additions & 2 deletions src/mongo_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ export interface PkFactory {

/** @public */
export type SupportedTLSConnectionOptions = Pick<
TLSConnectionOptions,
Extract<keyof TLSConnectionOptions, (typeof LEGAL_TLS_SOCKET_OPTIONS)[number]>
TLSConnectionOptions & {
allowPartialTrustChain?: boolean;
},
(typeof LEGAL_TLS_SOCKET_OPTIONS)[number]
>;

/** @public */
Expand Down