feat(NODE-6446): deprecate legacy timeout options #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocking on #4284 |
baileympearson
force-pushed
the
NODE-6090
branch
from
d224fff to
c3f31da
Compare
baileympearson
force-pushed
the
NODE-6090
branch
from
c3f31da to
4fd4b24
Compare
W-A-James
changed the title
nbbeeken
reviewed
Oct 23, 2024
src/write_concern.ts
Outdated
Comment on lines
69
to
70
| /** Specify a time limit to prevent write operations from blocking indefinitely | ||
| * @deprecated Will be removed in the next major version. Please use timeoutMS */ |
There was a problem hiding this comment.
Let's use the expectDeprecated helper in tsd to assert none of these get undeprecated and it will help us find them all later. It helps if we refactor the way we declare the options but we preserve these docs and info.
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Oct 24, 2024
nbbeeken
approved these changes
Oct 25, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
socketTimeoutMSas deprecatedwaitQueueTimeotuMSas deprecatedmaxTimeMSand associated setter methods as deprecatedtimeoutMSoverwTimeoutMSIs there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript…ver selection