fix(NODE-6454): use timeoutcontext for state machine execute() cursor options #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
added
the
Primary Review
aditi-khare-mongoDB
approved these changes
Oct 24, 2024
|
LGTM, I'll wait for CI to finish before approving Edit: I'll wait for the end to end test case before approving |
baileympearson
force-pushed
the
NODE-6454
branch
from
569462e to
666575d
Compare
aditi-khare-mongoDB
requested changes
Oct 28, 2024
baileympearson
force-pushed
the
NODE-6454
branch
2 times, most recently
from
f1f5d0d to
5660c45
Compare
baileympearson
commented
Oct 30, 2024
| .catch(e => e); | ||
| it( | ||
| 'the bulk write operation times out', | ||
| mergeTestMetadata(metadata, { |
There was a problem hiding this comment.
This should fix some of the flakiness we see in CI.
aditi-khare-mongoDB
requested changes
Oct 30, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
baileympearson
force-pushed
the
NODE-6454
branch
from
5660c45 to
91f2b34
Compare
aditi-khare-mongoDB
approved these changes
Oct 31, 2024
aditi-khare-mongoDB
added
Team Review
nbbeeken
approved these changes
Oct 31, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Instead of using the remainingTimeMS as the value for
timeoutMSwhen running cursor operations in the state machine, we provide a CursorTimeoutContext that wraps the original timeout.Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript