DRIVERS-1915: Change stream support for point-in-time pre and post-images #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 8, 2022
Introduces fullDocumentBeforeChange option. Tests for specifying "whenAvailable" and "required" for both fullDocument and fullDocumentBeforeChange (requires MongoDB 6.0+ with changeStreamPreAndPostImages enabled on the collection). Tests synced with mongodb/specifications#1176
jmikola
changed the title
jmikola
changed the title
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 8, 2022
Introduces fullDocumentBeforeChange option. Tests for specifying "whenAvailable" and "required" for both fullDocument and fullDocumentBeforeChange (requires MongoDB 6.0+ with changeStreamPreAndPostImages enabled on the collection). Tests synced with mongodb/specifications#1176
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 8, 2022
Introduces fullDocumentBeforeChange option. Tests for specifying "whenAvailable" and "required" for both fullDocument and fullDocumentBeforeChange (requires MongoDB 6.0+ with changeStreamPreAndPostImages enabled on the collection). Tests synced with mongodb/specifications#1176
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 11, 2022
Introduces fullDocumentBeforeChange option. Tests for specifying "whenAvailable" and "required" for both fullDocument and fullDocumentBeforeChange (requires MongoDB 6.0+ with changeStreamPreAndPostImages enabled on the collection). Intentionally omits mention of FULL_DOCUMENT_DEFAULT (related to PHPLIB-808) and FULL_DOCUMENT_BEFORE_CHANGE_OFF constants, since those redundantly specified default behavior. Tests synced with mongodb/specifications#1176
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 12, 2022
Introduces fullDocumentBeforeChange option. Tests for specifying "whenAvailable" and "required" for both fullDocument and fullDocumentBeforeChange (requires MongoDB 6.0+ with changeStreamPreAndPostImages enabled on the collection). Intentionally omits mention of FULL_DOCUMENT_DEFAULT (related to PHPLIB-808) and FULL_DOCUMENT_BEFORE_CHANGE_OFF constants, since those redundantly specified default behavior. Tests synced with mongodb/specifications#1176
benjirewis
reviewed
Apr 12, 2022
source/change-streams/tests/unified/change-streams-pre_and_post_images.yml
Outdated
Show resolved
Hide resolved
source/change-streams/tests/unified/change-streams-pre_and_post_images.yml
Show resolved
Hide resolved
jmikola
commented
Apr 12, 2022
benjirewis
approved these changes
Apr 13, 2022
source/change-streams/tests/unified/change-streams-pre_and_post_images.yml
Show resolved
Hide resolved
benjirewis
reviewed
Apr 13, 2022
|
|
||
| runOnRequirements: | ||
| - minServerVersion: "6.0.0" | ||
| topologies: [ replicaset, sharded-replicaset, load-balanced ] |
There was a problem hiding this comment.
I believe the CI is failing because of this line... Not sure why, though.
There was a problem hiding this comment.
Looking into this now. I just realized change-streams were never added to the Unified Test Format Makefile and just did so now. It validates locally, so I'll have to sort out how the CI task differs.
I based this on I object to all of the existing tests having |
Per DRIVERS-2231, drivers no longer send this value, but it is technically accepted (like "off" for fullDocumentBeforeChange).
baileympearson
added a commit
to mongodb/node-mongodb-native
that referenced
this pull request
May 17, 2022
- spec tests synced from mongodb/specifications#1176
baileympearson
added a commit
to mongodb/node-mongodb-native
that referenced
this pull request
May 18, 2022
- spec tests synced from mongodb/specifications#1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-1915
POC: mongodb/mongo-php-library#911
Note: testing may require starting mongod with
--setParameter featureFlagChangeStreamPreAndPostImages=trueif the "latest" server build does not include SERVER-52282.