Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of logConfiguration makes it impossible to add awslogs options #26

Closed
krcz opened this issue Mar 19, 2020 · 3 comments · Fixed by #27
Closed

Type of logConfiguration makes it impossible to add awslogs options #26

krcz opened this issue Mar 19, 2020 · 3 comments · Fixed by #27
Assignees
@jasonwalsh
Labels
bug Something isn't working released

Comments

@krcz
Copy link

krcz commented Mar 19, 2020

Type of logConfiguration field in this module is map(string) which means that adding subdictionary under options key is impossible while it is a common usage pattern:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_awslogs.html#specify-log-config
jasonwalsh pushed a commit that referenced this issue Mar 21, 2020
fix: update type of logConfiguration variable
0e406af 
Fixes #26
@jasonwalsh jasonwalsh mentioned this issue Mar 21, 2020
Merged
jasonwalsh added a commit that referenced this issue Mar 21, 2020
@jasonwalsh
fix: update type of logConfiguration variable (#27)
041b144 
Fixes #26
@jasonwalsh jasonwalsh self-assigned this Mar 21, 2020
@jasonwalsh jasonwalsh added the bug Something isn't working label Mar 21, 2020
jasonwalsh pushed a commit that referenced this issue Mar 21, 2020
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
026f49e 
## [2.0.1](v2.0.0...v2.0.1) (2020-03-21)

### Bug Fixes

* update type of logConfiguration variable ([#27](#27)) ([041b144](041b144)), closes [#26](#26)
@jasonwalsh
Copy link
Member

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jasonwalsh
Copy link
Member

@krcz it should be fixed now. Please try using the latest release.

@krcz
Copy link
Author

krcz commented Mar 24, 2020 •
edited
Loading

@jasonwalsh Verified, it works perfectly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonwalsh jasonwalsh

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update type of logConfiguration variable mongodb/terraform-aws-ecs-task-definition
2 participants
@jasonwalsh @krcz