Avoid corrupt documents #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 25, 2020 10:55
If an embedded document has its version incremented, but an ancester is flagged for destroy and the root document is not, then this causes conflicts, which are written to the otherwise empty embedded document, leaving a corrupt document in storage. Note that this only happends with the parent document cascades callbacks.
|
|
|
This makes sense, tough one, will merge on green. |
1 similar comment
This was referenced Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracking history on deeply embedded documents where callbacks are cascaded from the root document, incrementing the version number of the embedded docs that are removed because an ancestor is removed causes conflicts in the atomic update, which are then written into an empty document in the 2nd pass, causing corrupt embedded documents to be persisted. Here we avoid updating the version of a document if an ancestor is being destroyed.