Add support for Mongoid 7 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Down with paranoia. We do need to fix the build, whether the failures are new in the test environment or not, before we get this merged. |
|
Yeah no worries, I'm happy to look into that in the morning. Aiming for all
greens!
|
|
@dblock Tests passing on all versions 🎉 |
dblock
reviewed
Aug 15, 2018
| @@ -1,5 +1,6 @@ | |||
| ## 5.3.4 (Next) | |||
| ## 6.0.0 (Next) | |||
There was a problem hiding this comment.
You also want to increment version.rb.
|
I'll take a closer look shortly. What was the issue? |
|
Oh the ... |
|
I just merged this, great work. Want to help co-maintain the gem @kailan? You could do the next release. Give me your rubygems email if so. |
|
I would love to @dblock 👍 |
|
Great, accept the invite at https://github.com/mongoid/mongoid-slug/invitations. Added you to Rubygems. Opened #253 for next release, thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Mongoid 7 (whilst maintaining backwards compatibility) at the expense of removing mongoid_paranoia due to its lack of support for the latest Mongoid version. Although this may be considered a blocker for releasing a new version, a quick look at the network tab for this repository shows many users forking the repository and performing hacky updates (breaking paranoia support along with other features) to allow their dependent applications to update to Mongoid 7, as paranoia is a feature used by very few users. For users that wish to continue using paranoia with older versions, they are still available. Existing applications using proper versioning in Gemfiles will not be affected.
This pull request also introduces the use of Mongoid::Compatibility
mongoid5_or_newer?andmongoid6_or_newer?methods rather than strict version checks, allowing future non-breaking Mongoid releases to be supported without the need for updates.Tests pass locally on all Mongoid versions from 3-7, although Travis is reporting failures for Mongoid 3 and 4 due to issues with the test environment. Running a Travis build on the current HEAD also fails for the same reasons, so this pull request is not the cause for these failures.