Add Github Actions and remove Travis CI #260
Conversation
|
@dblock can you make me an admin on this repo? I'd like to do some gardening. |
|
@johnnyshields Made you admin, LMK if you didn't get the invite? |
| @@ -596,18 +596,19 @@ class Person | |||
|
|
|||
| context 'with a value exceeding mongodb max index key' do | |||
| if Mongoid::Compatibility::Version.mongoid5_or_newer? | |||
| it 'errors with a model without a max length' do | |||
| xit 'errors with a model without a max length' do | |||
There was a problem hiding this comment.
Something about current MongoDB version?
There was a problem hiding this comment.
Yeah I'm not sure. I was meaning to look into this more...
I can merge now so looks like I'm an admin. Thanks! |
|
I merged it, will leave it to you to make sure it really works. For the failing tests, if you can't solve that quickly, open an issue? |
|
I shouldn't have merged too fast ;) It's borked. Will you take a look? Also fix the badge in README pls. |
|
Sure, thanks for merging. Well, Travis was also broken, so its not worse than it was, but should fix it soon |
No description provided.