Refactor: Replace all usages of "protected" with "private" (#85)

mongoid · Nov 7, 2023 · 6de4dcb · 6de4dcb
1 parent 1b14690
commit 6de4dcb
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 * [#75](https://github.com/mongoid/mongoid_orderable/pull/75): Fix: Preserve position when creating new records.
 * [#84](https://github.com/mongoid/mongoid_orderable/pull/84): Feature: Use Mongo::QueryCache if available.
+* [#85](https://github.com/mongoid/mongoid_orderable/pull/85): Refactor: Replace all usages of "protected" with "private".
 
 ### 6.0.4 (2023/02/01)
 

diff --git a/lib/mongoid/orderable/configs/field_config.rb b/lib/mongoid/orderable/configs/field_config.rb
@@ -41,7 +41,7 @@ def global_config
         lock_collection: cfg.lock_collection }
     end
 
-    protected
+    private
 
     def assign_options(options)
       @options = global_config

diff --git a/lib/mongoid/orderable/generators/base.rb b/lib/mongoid/orderable/generators/base.rb
@@ -10,7 +10,7 @@ def initialize(klass)
       @klass = klass
     end
 
-    protected
+    private
 
     def generate_method(name, &block)
       klass.send(:define_method, name, &block)

diff --git a/lib/mongoid/orderable/generators/listable.rb b/lib/mongoid/orderable/generators/listable.rb
@@ -9,7 +9,7 @@ def generate(field_name)
       generate_aliased_helpers(field_name)
     end
 
-    protected
+    private
 
     def generate_list_helpers(field_name)
       generate_method("next_#{field_name}_item") do

diff --git a/lib/mongoid/orderable/generators/lock_collection.rb b/lib/mongoid/orderable/generators/lock_collection.rb
@@ -25,7 +25,7 @@ class #{model_name}
       KLASS
     end
 
-    protected
+    private
 
     def model_exists?(model_name)
       base = ::Mongoid::Orderable::Models

diff --git a/lib/mongoid/orderable/generators/movable.rb b/lib/mongoid/orderable/generators/movable.rb
@@ -10,7 +10,7 @@ def generate(field_name)
       generate_shorthand_helpers(field_name)
     end
 
-    protected
+    private
 
     def generate_move_to_helpers(field_name)
       generate_method("move_#{field_name}_to") do |target_position|

diff --git a/lib/mongoid/orderable/generators/scope.rb b/lib/mongoid/orderable/generators/scope.rb
@@ -11,7 +11,7 @@ def generate(field_name, order_scope)
       end
     end
 
-    protected
+    private
 
     def criteria(order_scope)
       case order_scope

diff --git a/lib/mongoid/orderable/handlers/base.rb b/lib/mongoid/orderable/handlers/base.rb
@@ -11,7 +11,7 @@ def initialize(doc)
       reset_new_record
     end
 
-    protected
+    private
 
     delegate :orderable_keys,
              :orderable_field,

diff --git a/lib/mongoid/orderable/handlers/document_transactional.rb b/lib/mongoid/orderable/handlers/document_transactional.rb
@@ -13,7 +13,7 @@ def after_create
       super
     end
 
-    protected
+    private
 
     def apply_all_positions
       with_transaction { super }

diff --git a/lib/mongoid/orderable/handlers/transaction.rb b/lib/mongoid/orderable/handlers/transaction.rb
@@ -35,7 +35,7 @@ def with_transaction(&block)
       end
     end
 
-    protected
+    private
 
     def do_transaction(&_block)
       doc.class.with_session(session_opts) do |session|

diff --git a/lib/mongoid/orderable/installer.rb b/lib/mongoid/orderable/installer.rb
@@ -18,7 +18,7 @@ def setup
       generate_all_helpers
     end
 
-    protected
+    private
 
     def field_name
       config[:field_options][:as] || config[:field]

diff --git a/lib/mongoid/orderable/mixins/callbacks.rb b/lib/mongoid/orderable/mixins/callbacks.rb
@@ -23,7 +23,7 @@ module Callbacks
                to: :orderable_handler,
                prefix: :orderable
 
-      protected
+      private
 
       def orderable_handler
         @orderable_handler ||= self.class.orderable_handler_class.new(self)

diff --git a/lib/mongoid/orderable/mixins/movable.rb b/lib/mongoid/orderable/mixins/movable.rb
@@ -44,7 +44,7 @@ def move_#{symbol}!(options = {})
       KLASS
     end
 
-    protected
+    private
 
     def move_all
       @move_all ||= {}