WIP - set position for new record #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…position Fix specs for new record position
Fix problem with position
|
@johnnyshields Hey, what with this PR? I have issue - #78. Checked yours solution on my enviroment and my specs are green. Maybe we can merge and create new release? Or smth like that. Thx. |
|
@johnnyshields I can help CR, @skalibog feel free to finish this PR for us |
|
Hi guys, yeah, I'm working on this now, need another week or so but it's on the chopping block for me to get into production. FWIW I am running this branch in staging with no issues for ~1 month, but I want to do one last review/cleanup on the code before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.