Add mgos_sntp_get_last_synced_uptime() #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojer
reviewed
Feb 15, 2021
include/mgos_sntp.h
Outdated
|
|
||
| double mgos_sntp_get_last_synced_uptime(void); | ||
|
|
||
| bool mgos_sntp_is_synced(void); |
There was a problem hiding this comment.
i think we don't need this method, just add comment to mgos_sntp_get_last_synced_uptime that it returns 0 until synced.
There was a problem hiding this comment.
It's just a shorthand for the mos frequent use of this API, including
Line 115 in f7f4c04
kzyapkov
force-pushed
the
add_is_synced
branch
3 times, most recently
from
78cef6c
to
0445a80
Compare
kzyapkov
force-pushed
the
add_is_synced
branch
from
0445a80
to
21ece85
Compare
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, force-pushing a branch to it's merge-base with the upstream main branch automatically closes the associated pull request. Sorry about the duplicate.
This adds
double mgos_sntp_get_last_synced_uptime()as proposed in #3 , but keepsbool mgos_sntp_is_synced()since that's what is needed most frequently anyway, including in the source of this lib itself.