feat: datestamp filename of exported SQL file. (#5136)

monicahq · May 23, 2021 · a658fcf · a658fcf
1 parent 6378bc1
commit a658fcf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/Http/Controllers/SettingsController.php b/app/Http/Controllers/SettingsController.php
@@ -8,6 +8,7 @@
 use Illuminate\Http\Request;
 use App\Helpers\LocaleHelper;
 use App\Helpers\AccountHelper;
+use Illuminate\Support\Carbon;
 use App\Helpers\TimezoneHelper;
 use App\Models\Contact\Contact;
 use App\Jobs\ExportAccountAsSQL;
@@ -203,8 +204,10 @@ public function exportToSql()
 
         $adapter = disk_adapter(ExportAccountAsSQL::STORAGE);
 
+        $exportdate = Carbon::now(DateHelper::getTimezone())->format('Y-m-d');
+
         return response()
-            ->download($adapter->getPathPrefix().$path, 'monica.sql')
+            ->download($adapter->getPathPrefix().$path, "monica-export.$exportdate.sql")
             ->deleteFileAfterSend(true);
     }
 

diff --git a/tests/Feature/SettingsTest.php b/tests/Feature/SettingsTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Feature;
 
 use Tests\FeatureTestCase;
+use Illuminate\Support\Carbon;
 use App\Models\Contact\Contact;
 use LaravelWebauthn\Models\WebauthnKey;
 use Illuminate\Foundation\Testing\DatabaseTransactions;
@@ -48,10 +49,12 @@ public function test_user_can_export_account()
 
         $response->assertSee(trans('settings.export_title'));
 
+        Carbon::setTestNow(Carbon::create(2021, 11, 25, 7, 0, 0));
+
         $response = $this->get(route('settings.sql'));
 
         $response->assertStatus(200);
-        $this->assertTrue($response->headers->get('content-disposition') == 'attachment; filename=monica.sql');
+        $this->assertTrue($response->headers->get('content-disposition') == 'attachment; filename=monica-export.2021-11-25.sql');
     }
 
     public function test_user_can_delete_account()