fix: Sort relationship by relationship types

[ashawe]

FIX #2395
Sort the array by relationshipType
if relationshipType occours for first time, save it and display it
else continue displaying other details

when relationshipType changes, it won't be equal to curr_relationship and hence will display it

UI CHANGES: replace the silver badge with

@djaiss

NOTE: test are not written in cypress yet

[CLAassistant]

All committers have signed the CLA.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[asbiin]

As I'm OK with the idea, the php code has no place in the bade template.

[asbiin]

I really don't like using @php in Laravel.
In every case, it could be done in the Controller instead, and that's the place it has to be moved.

[ashawe]

can you point me in the right direction and tell me in which file should I place the sort function and where does the $relationships array comes from, So I can sort them there itself and do the displaying here accordingly

[asbiin]

The relationships array comes from resources/views/people/relationship/index.blade.php file, and the ContactsController@show method. Each @include use another list of relationships (which is not really optimized code btw...)

You can call the getLocalizedName and store it in the relationship object using a map method, and reorder the collection with sortByCollator macro.

[asbiin]

closing this after long non-activity time

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.