feat: add date of creation in journal #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update forked repo
asbiin
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Thank you @sktlmarat !
There is some adaptation to make so it can be translated a better way, see my suggestions.
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
|
Thank you @asbiin for your feedback! |
Closed
asbiin
requested changes
Mar 21, 2021
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
asbiin
changed the title
asbiin
requested changes
Mar 21, 2021
resources/js/components/journal/partials/JournalContentEntry.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexis Saettler <alexis@saettler.org>
asbiin
approved these changes
Mar 21, 2021
|
🎉 This PR is included in version 2.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature for #4508
Added created at time on the journal entry (on UI and on the resource for journal entry).
The date on UI looks like this: