Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort and group relationships by relationship type #4985

Merged
merged 7 commits into from
Mar 21, 2021
Merged

fix: sort and group relationships by relationship type #4985

merged 7 commits into from
Mar 21, 2021

Conversation

dragosh635
Copy link

FIX #2395
Sort and group the relationship by relationshipType
Group the relationships and then show them all based on the group

@djaiss
UI CHANGES: removed the silver badge with the relationship type name localized
Print Screen here

Please let me know if I need to change something so that my PR gets merged.
I'm kind of a begginer in the opern source world :)

Thanks!
Dragos

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

@dragosh635 dragosh635 changed the title fix: sort and group relationships by relationship type #2395 fix: sort and group relationships by relationship type Mar 19, 2021
@dragosh635
Copy link
Author

Hello, I'm trying to make this PR to pass the Build Assets check and I cannot go by this error print screen here
Do you guys have any ideea why is this happening ?
I'ved already run yarn lint:all and yarn run prod but with no effect.

Thank you

…-relationships-according-to-relationshipType
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thank you @dragosh635

@asbiin
Copy link
Member

asbiin commented Mar 21, 2021

Hello, I'm trying to make this PR to pass the Build Assets check and I cannot go by this error print screen here
Do you guys have any ideea why is this happening ?
I'ved already run yarn lint:all and yarn run prod but with no effect.

Thank you

This build process is sometimes a little bit tricky - we'll get rid of it soon.
I've rebuild the assets myself.

@asbiin asbiin merged commit 105b74f into monicahq:master Mar 21, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Relationships
3 participants