Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update last called attribute #5614

Merged
merged 11 commits into from
Oct 26, 2021

Conversation

samfelgar
Copy link

@samfelgar samfelgar commented Oct 16, 2021

Fixes: #5541

DISCLAIMER: Although this feature changes some front end files, it doesn't change anything related to style or layout.

This feature creates a component to show the "last called" info and triggers an update whenever a call is added, updated or deleted.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • Tests have been added for the new code.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2021

CLA assistant check
All committers have signed the CLA.

@samfelgar samfelgar marked this pull request as ready for review October 17, 2021 02:05
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you
I just have one question/request, see below

resources/lang/en/people.php Outdated Show resolved Hide resolved
@samfelgar samfelgar requested a review from asbiin October 18, 2021 21:30
@samfelgar
Copy link
Author

@asbiin, the build action failed while installing the yarn dependencies... Is there anything I can do?

@asbiin
Copy link
Member

asbiin commented Oct 26, 2021

@samfelgar I've rerun it, that's fine

@asbiin asbiin merged commit 83e1d68 into monicahq:master Oct 26, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants