feat: add dependencies node and yarn in Dockerfile #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodejs and yarn are dependencies to install project and were missing in Dockerfile. The commit include that dependencies in scripts/Dockerfile to make easy the setup of the project in dev environments.
|
|
asbiin
requested changes
Oct 26, 2021
Co-authored-by: Alexis Saettler <alexis@saettler.org>
asbiin
approved these changes
Oct 27, 2021
|
Thank you @geidsonc |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing the initial setup of the project using docker-composer.dev and noticed the lack of some dependencies in the image.
I added this setting to my up stream and thought it might be useful for others who want to start easily and contribute to this project;.
The nodejs 14 and yarn are dependencies to install project and were missing in Dockerfile.
The commit include that dependencies in scripts/Dockerfile to make easy the setup of the project in dev environments.