Add listLatestObject and listOldestNObjects for s3 issue #309 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i have no idea why i have the helper func take a type parameter |
added 2 commits
February 7, 2021 19:36
paualarco
reviewed
Feb 9, 2021
paualarco
reviewed
Feb 9, 2021
paualarco
reviewed
Feb 9, 2021
added 2 commits
February 12, 2021 17:00
paualarco
reviewed
Feb 13, 2021
paualarco
reviewed
Feb 13, 2021
|
@cwgroppe just left another small comment and we could get it merged :) |
|
@cwgroppe thanks for addressing the comments! merged :) |
|
@paualarco thanks for being patient with we, this is my first time contributing to an open source project and I've been the only dev on my team for about 2 years, so I haven't had a review in a while. It's been a great learning experience and I plan to continue to add to this project. Hopefully it will go smoother next time. |
|
@cwgroppe no need to say thanks for that, I appreciate your contribution as well as your interest in the project! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for Create methods for listingLatest and listingOldestN S3 objects #309.
listingLatest -> listLatestObject
listingOldestN -> listOldestNObjects
Also added to it test in S3Suite for these functions.
resolve #309