Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Scala 2.13 deprecations #114

Closed
Avasil opened this issue Sep 14, 2019 · 0 comments
Closed

Handle Scala 2.13 deprecations #114

Avasil opened this issue Sep 14, 2019 · 0 comments
Labels
good first issue

Comments

@Avasil
Copy link
Collaborator

Avasil commented Sep 14, 2019

Scala 2.13 has few deprecations related to Map.mapValues and JavaConverters, we probably need something similar to:

https://github.com/monix/monix/blob/master/monix-execution/shared/src/main/scala_2.13-/monix/execution/compat.scala

so we can fully reuse sources between versions.

I didn't include it in #113 and just disabled fatal warnings for now
paualarco added a commit to paualarco/monix-kafka that referenced this issue Jan 10, 2021
@paualarco
Enable '-Xfatal-warnings' compiler flag (monix#114)
b92e2f3
Avasil pushed a commit that referenced this issue Jan 11, 2021
@paualarco
Enable '-Xfatal-warnings flag (#114) (#248)
0b8c94e 
* Removed method type parameters

* Enable '-Xfatal-warnings' compiler flag (#114)

* Update headers

* Replaced Monix deprecated method
@Avasil Avasil closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Avasil