Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): add Khmer (@Earpengai) #6128

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Conversation

Earpengai
Copy link
Contributor

Description

This PR adds support for the Khmer (Cambodian) language to Monkeytype.
The implementation includes:

  1. Added khmer.json with:
  • Common Khmer words used in daily conversation
  • Proper language metadata (BCP47: km-KH)
  1. Updated required configuration files:
  • Added khmer.json to languages folder
  • Added Khmer to _list.json
  • Updated _groups.json to include Khmer in Asian languages group

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 23, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec changed the title feat(language): add Khmer (Cambodian) language support (@Earpengai) feat(language): add Khmer (@Earpengai) Dec 23, 2024
@Miodec Miodec merged commit 81baa91 into monkeytypegame:master Dec 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants