Fixed the generated C# for constant references to primitives.

Signed-off-by: Dimitar Dobrev <dpldobrev@protonmail.com>
mono · Oct 13, 2018 · 0c87a77 · 0c87a77
1 parent 2fe8d21
commit 0c87a77
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/src/Generator/Generators/CSharp/CSharpMarshal.cs b/src/Generator/Generators/CSharp/CSharpMarshal.cs
@@ -186,8 +186,7 @@ public override bool VisitPointerType(PointerType pointer, TypeQualifiers quals)
                 if (Context.Function != null &&
                     Context.Function.OperatorKind == CXXOperatorKind.Subscript)
                 {
-                    if (type.IsPrimitiveType(primitive) ||
-                        new QualifiedType(pointer, quals).IsConstRefToPrimitive())
+                    if (type.IsPrimitiveType(primitive))
                     {
                         Context.Return.Write("*");
                     }
@@ -199,6 +198,9 @@ public override bool VisitPointerType(PointerType pointer, TypeQualifiers quals)
                     }
                 }
 
+                if (new QualifiedType(pointer, quals).IsConstRefToPrimitive())
+                    Context.Return.Write("*");
+
                 Context.Return.Write(Context.ReturnVarName);
                 return true;
             }

diff --git a/tests/CSharp/CSharp.Tests.cs b/tests/CSharp/CSharp.Tests.cs
@@ -54,6 +54,7 @@ public void TestUncompilableCode()
                 hasSecondaryBaseWithAbstractWithDefaultArg.Abstract();
                 hasSecondaryBaseWithAbstractWithDefaultArg.AbstractWithNoDefaultArg(foo);
             }
+            Assert.That(foo.ReturnConstRef(), Is.EqualTo(5));
         }
         using (var hasOverride = new HasOverrideOfHasPropertyWithDerivedType())
             hasOverride.CauseRenamingError();

diff --git a/tests/CSharp/CSharp.cpp b/tests/CSharp/CSharp.cpp
@@ -60,6 +60,11 @@ void Foo::set_width(int value)
 {
 }
 
+const int& Foo::returnConstRef()
+{
+    return rename;
+}
+
 const int Foo::rename;
 
 int Foo::makeFunctionCall()

diff --git a/tests/CSharp/CSharp.h b/tests/CSharp/CSharp.h
@@ -26,6 +26,7 @@ class DLL_API Foo
     void takesStdVector(const std::vector<int>& vector);
     int width();
     void set_width(int value);
+    const int& returnConstRef();
 
     static const int rename = 5;
     static int makeFunctionCall();