This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
[Android] Fixing the previous clang fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that `+neon` architecture extension is required (and accepted) only by the (buggy) clang 3.x in NDK r14 while both gcc and clang > 3 error out when they see `+neon`... So, the magic incantation contained in this commit *appears* to work for all of them. Tested manually with clang 3.x, clang 7.x, gcc 7.x (aarch64 cross-compiler on Linux) and gcc 8.x (aarch64 cross-compiler on Linux)
grendello
force-pushed
the
fix-android-ndk18
branch
from
fcffff5
to
6ca625c
Compare
lewurm
approved these changes
Jan 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
+neonarchitecture extension is required (and accepted) only bythe (buggy) clang 3.x in NDK r14 while both gcc and clang > 3 error out when
they see
+neon... So, the magic incantation contained in this commit appearsto work for all of them. Tested manually with clang 3.x, clang 7.x, gcc
7.x (aarch64 cross-compiler on Linux) and gcc 8.x (aarch64 cross-compiler on
Linux)