This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Add TypeConverter fallback to DefaultValueAttribute #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9354) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
@MaximLipnin that won't compile with mcs :-( |
marek-safar
reviewed
Jan 16, 2019
| @@ -36,7 +36,24 @@ public DefaultValueAttribute(Type type, string value) | |||
| // load an otherwise normal class. | |||
| try | |||
| { | |||
| if (type.IsSubclassOf(typeof(Enum))) | |||
| #if MONO | |||
There was a problem hiding this comment.
Please change this to __MonoCS__ which is mcs specific define
This was referenced Jan 18, 2019
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Jan 18, 2019
marek-safar
pushed a commit
that referenced
this pull request
Jan 18, 2019
* Add TypeConverter fallback to DefaultValueAttribute (dotnet/coreclr#19354) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Workaround for mcs * Use mcs specific define
marek-safar
pushed a commit
that referenced
this pull request
Jan 18, 2019
* Add TypeConverter fallback to DefaultValueAttribute (dotnet/coreclr#19354) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Workaround for mcs * Use mcs specific define
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From dotnet#31773