This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
forked from dotnet/corefx
-
Notifications
You must be signed in to change notification settings - Fork 35
Use the proper method for getting fully resolved temporary file paths #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@monojenkins backport to 2019-08 |
DanglingSymlinkMove() in Move.cs needs to be fixed as well |
and I think we didn't backport to 2019-02, only 06+ |
oh yeah, I made the same mistake on both... |
This was a bug in the tests from mono/mono#15616
alexischr
force-pushed
the
fix-gh-15616
branch
from
August 20, 2019 18:05
4a7412e
to
e39bdd0
Compare
akoeplinger
reviewed
Aug 20, 2019
akoeplinger
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed this test passes now on my iPad device. Thanks!
@monojenkins backport mono-2019-08 |
This was referenced Aug 20, 2019
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 20, 2019
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 20, 2019
akoeplinger
added a commit
to mono/mono
that referenced
this pull request
Aug 20, 2019
Pushed to mono repo on 2019-06 and up. |
This was referenced Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug in the tests from mono/mono#15616