Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Use the proper method for getting fully resolved temporary file paths #332

Merged
merged 4 commits into from
Aug 20, 2019

Conversation

alexischr
Copy link

This was a bug in the tests from mono/mono#15616

@alexischr
Copy link
Author

@monojenkins backport to 2019-08
@monojenkins backport to 2019-06
@monojenkins backport to 2019-02

@akoeplinger
Copy link
Member

DanglingSymlinkMove() in Move.cs needs to be fixed as well

@akoeplinger
Copy link
Member

and I think we didn't backport to 2019-02, only 06+

@alexischr
Copy link
Author

oh yeah, I made the same mistake on both...

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this test passes now on my iPad device. Thanks!

@akoeplinger akoeplinger merged commit 4b37168 into master Aug 20, 2019
@akoeplinger akoeplinger deleted the fix-gh-15616 branch August 20, 2019 18:48
@akoeplinger
Copy link
Member

@monojenkins backport mono-2019-08
@monojenkins backport mono-2019-06

akoeplinger pushed a commit that referenced this pull request Aug 20, 2019
akoeplinger pushed a commit that referenced this pull request Aug 20, 2019
akoeplinger added a commit to mono/mono that referenced this pull request Aug 20, 2019
akoeplinger added a commit to mono/mono that referenced this pull request Aug 20, 2019
akoeplinger added a commit to mono/mono that referenced this pull request Aug 20, 2019
@akoeplinger
Copy link
Member

Pushed to mono repo on 2019-06 and up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants