[build] add extension point for consuming repositories #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#9237 Context: dotnet/android-tools@34e98e2 Using the latest .NET 9 RC 1 builds, dotnet/android repo fails to restore with: external/debugger-libs/Mono.Debugging/Mono.Debugging.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.34 To solve this, we generally set `$(RestoreAdditionalProjectSources)` to a feed that would include the 6.0.34 runtime packages. Add an "extension point" to mono/debugger-libs, that would allow us to have a submodule like: external/debugger-libs Then would allow us to create the file: external/debugger-libs.override.props This file would set `$(RestoreAdditionalProjectSources)` until the 6.0.34 runtime is released.
|
@mauroa can you please check if this will not cause any side effect on our internal extension? |
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Aug 21, 2024
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Aug 21, 2024
Changes: dotnet/sdk@df30800...1854762 Changes: dotnet/runtime@0fbd814...fe0cfd5 Changes: dotnet/emsdk@edf3e90...459c929 Changes: dotnet/cecil@b9d928a...ed276e7 Updates: * Microsoft.NET.Sdk: from 9.0.100-rc.1.24419.12 to 9.0.100-rc.1.24421.9 * Microsoft.NETCore.App.Ref: from 9.0.0-rc.1.24414.5 to 9.0.0-rc.1.24420.11 * Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-rc.1.24402.2 to 9.0.0-rc.1.24416.2 * Microsoft.NET.ILLink.Tasks: from 9.0.0-rc.1.24414.5 to 9.0.0-rc.1.24420.11 * Microsoft.DotNet.Cecil: from 0.11.5-alpha.24379.1 to 0.11.5-alpha.24413.1 ~~ Other changes ~~ * Feeds for dotnet/runtime 8.0.9 Context: https://github.com/dotnet/android/blob/45af0b5ffe0b4c59d2282a514abedec39f8de39f/NuGet.config#L7-L10 * Feeds for dotnet/runtime 6.0.34 Context: https://github.com/dotnet/runtime/commits/release/6.0 * Bump to mono/debugger-libs@d5664344 Changes: mono/debugger-libs@84c5c67...d566434 * Create `external/debugger-libs.override.props` Context: mono/debugger-libs#412 Set `$(DisableTransitiveFrameworkReferenceDownloads)` for mono/debugger-libs. Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#9237
Context: dotnet/android-tools@34e98e2
Using the latest .NET 9 RC 1 builds, dotnet/android repo fails to restore with:
To solve this, we generally set
$(RestoreAdditionalProjectSources)to a feed that would include the 6.0.34 runtime packages.Add an "extension point" to mono/debugger-libs, that would allow us to have a submodule like:
Then would allow us to create the file:
This file would set
$(RestoreAdditionalProjectSources)until the 6.0.34 runtime is released.